London10-Afsha-Hossain-HTML/CSS-Week2#242
London10-Afsha-Hossain-HTML/CSS-Week2#242Afsha10 wants to merge 2 commits intoCodeYourFuture:mainfrom
Conversation
Afsha10
changed the title
SallyMcGrath
left a comment
SallyMcGrath
left a comment
There was a problem hiding this comment.
Thanks for this, @Afsha10 ! Your code is valid and scores 100 on Lighthouse. Well done!
I have dropped a few comments and asked a few questions. Take a look and have a think. Few more questions:
- There are a few requirements you have missed. Can you spot them?
- Would you be happy to put this design on your portfolio? If not, why not, and what would you do to make it a portfolio piece?
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "liveServer.settings.port": 5501 | |||
There was a problem hiding this comment.
You've added a bunch of files from your repo that shouldn't be here. Usually this happens when you do git add . . This is not a good way to add your files with git. Add your files one by one, individually and with purpose.
Later in the course, you might have 5,000 files or more (node modules) that should not be committed. Imagine the mess!
| margin: 1rem; | ||
| } | ||
|
|
||
| .select-delivery-date { |
There was a problem hiding this comment.
It looks like you've applied the same styles to all these classes. Is there a way you could apply one style to all the classes? What does "class" actually mean?
| <section class="select-colour"> | ||
| <label for="color-picker">Choose your t-shirt colour from the three available colours</label> | ||
| <input type="color" list="presets" id="color-picker"> | ||
| <datalist id="presets"> |
| <form> | ||
| <!-- write your html here--> | ||
| <!-- try writing out the requirements first--> | ||
| <fieldset class="validate-account"> |
| </datalist> | ||
| </section> | ||
|
|
||
| <section class="select-size"> |
There was a problem hiding this comment.
You've used section here and not fieldset. Can you talk through why?
| </section> | ||
|
|
||
| <section class="select-size"> | ||
| <div> |
There was a problem hiding this comment.
And here you've used a bunch of divs. What are these divs doing in the code? What effect do they have?
Something special happens with fieldset and radio inputs. Can you find out what?
2 participants
No description provided.